Skip to content

Skip useless recursion in freshening and late-bound-region substitution#26055

Merged
bors merged 1 commit into
rust-lang:masterfrom
arielb1:smart-fold
Jun 10, 2015
Merged

Skip useless recursion in freshening and late-bound-region substitution#26055
bors merged 1 commit into
rust-lang:masterfrom
arielb1:smart-fold

Conversation

@arielb1

@arielb1 arielb1 commented Jun 6, 2015

Copy link
Copy Markdown
Contributor

Before:
581.72user 4.75system 7:42.74elapsed 126%CPU (0avgtext+0avgdata 1176224maxresident)k
llvm took 359.183

After:
550.63user 5.09system 7:20.28elapsed 126%CPU (0avgtext+0avgdata 1165516maxresident)k
llvm took 354.801

@rust-highfive

Copy link
Copy Markdown
Contributor

r? @pnkfelix

(rust_highfive has picked a reviewer for you, use r? to override)

@arielb1

arielb1 commented Jun 6, 2015

Copy link
Copy Markdown
Contributor Author

r? @nikomatsakis

@arielb1 arielb1 changed the title Skip useless recursion in freshening and late-bound-region substitutio Skip useless recursion in freshening and late-bound-region substitution Jun 6, 2015
@bors

bors commented Jun 8, 2015

Copy link
Copy Markdown
Collaborator

☔ The latest upstream changes (presumably #26018) made this pull request unmergeable. Please resolve the merge conflicts.

Before:
581.72user 4.75system 7:42.74elapsed 126%CPU (0avgtext+0avgdata 1176224maxresident)k
llvm took 359.183

After:
550.63user 5.09system 7:20.28elapsed 126%CPU (0avgtext+0avgdata 1165516maxresident)k
llvm took 354.801
@arielb1

arielb1 commented Jun 8, 2015

Copy link
Copy Markdown
Contributor Author

Rebased

@nikomatsakis

Copy link
Copy Markdown
Contributor

@bors r+ Looks nice! Sorry, been neglecting my review queue last few days...

@bors

bors commented Jun 9, 2015

Copy link
Copy Markdown
Collaborator

📌 Commit 39b9bea has been approved by nikomatsakis

@bors

bors commented Jun 10, 2015

Copy link
Copy Markdown
Collaborator

⌛ Testing commit 39b9bea with merge 5ea3ed0...

bors added a commit that referenced this pull request Jun 10, 2015
Before:
581.72user 4.75system 7:42.74elapsed 126%CPU (0avgtext+0avgdata 1176224maxresident)k
llvm took 359.183

After:
550.63user 5.09system 7:20.28elapsed 126%CPU (0avgtext+0avgdata 1165516maxresident)k
llvm took 354.801
@bors

bors commented Jun 10, 2015

Copy link
Copy Markdown
Collaborator

@bors bors merged commit 39b9bea into rust-lang:master Jun 10, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants